Implement all CSV reader options #1361
Open
+712
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI @djouallah |
This was referenced Feb 1, 2026
nuno-faria
approved these changes
Feb 3, 2026
Comment on lines
+40
to
+44
| If you require additional control over how to read the CSV file, you can use | ||
| :py:class:`~datafusion.options.CsvReadOptions` to set a variety of options. | ||
|
|
||
| .. code-block:: python | ||
Contributor
There was a problem hiding this comment.
I think it would be nice to have a link to docs.rs or similar that points to all available options for CsvReadOptions.
Comment on lines
+71
to
+72
| terminator: Optional line terminator character. If ``None``, uses CRLF. | ||
| Must be a single ASCII character. |
Contributor
There was a problem hiding this comment.
I'm surprised the default is CRLF.
Comment on lines
+752
to
+760
| csv_content = "name;age;city\nAlice;30;New York\nBob;25\n#Charlie;35;Paris" | ||
| csv_path.write_text(csv_content) | ||
|
|
||
| ctx = SessionContext() | ||
|
|
||
| # Test with CsvReadOptions | ||
| options = CsvReadOptions( | ||
| has_header=True, delimiter=";", comment="#", truncated_rows=True | ||
| ) |
Contributor
There was a problem hiding this comment.
Should more parameters be tested? Like "quote", "truncated_rows", "compression", "null_regex", ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1358
Rationale for this change
This change allows access to ALL csv reader options available in the upstream DataFusion repository. It adds a builder pattern on setting options for a more pleasant user experience, or they can specify each value individually in the constructor.
What changes are included in this PR?
CsvReaderOptionsclass and underlying structread_csvandregister_csvAre there any user-facing changes?
This change is fully backwards compatible.